src/beacon_root: gas optimization #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lmittmann, thanks for your PR. Unfortunately this contract is already deployed to mainnet so we won't be accepted additional changes to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small gas optimization for the beacon_root-contract.
stopat the end of the contract: the execution stops, if the end of the contract is reached. an explicitstopat the end is not required.iszero:jumpijumps, if the condition is non-zero. thus, theinput_timestampcan be used as the condition directly. This reduces the gas consumption of the execution with valid input data by 2 (-3 for dropping theiszero, +1 for an extrajumpdest)